Wizard: Add firewall to Review step (HMS-5357) #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on #2767, so that will need to get merged first. |
|
/jira-epic HMS-5168 |
schutzbot
changed the title
regexowl
force-pushed
the
firewall-on-review-step
branch
2 times, most recently
from
cf33a94 to
ee797cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
+ Coverage 84.55% 84.60% +0.04%
==========================================
Files 190 190
Lines 21811 21881 +70
Branches 2169 2181 +12
==========================================
+ Hits 18442 18512 +70
Misses 3347 3347
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
firewall-on-review-step
branch
3 times, most recently
from
166bbf6 to
72765ba
Compare
This adds a firewall expandable to the Review step.
regexowl
force-pushed
the
firewall-on-review-step
branch
from
72765ba to
e8662f8
Compare
avitova
reviewed
Jan 29, 2025
| <TextListItem component={TextListItemVariants.dd}> | ||
| <CodeBlock> | ||
| <CodeBlockCode> | ||
| {firewall.ports ? firewall.ports.join(' ') : 'None'} |
There was a problem hiding this comment.
I feel like this was the intention. 🤔
Suggested change
| {firewall.ports ? firewall.ports.join(' ') : 'None'} | |
| {firewall.ports.length ? firewall.ports.join(' ') : 'None'} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a firewall expandable to the Review step.
JIRA: HMS-5357